Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds React 19 RC and React-DOM 19 RC to the list of peer dependencies #2952

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Adds React 19 RC and React-DOM 19 RC to the list of peer dependencies #2952

merged 4 commits into from
Jun 19, 2024

Conversation

BenAHammond
Copy link
Contributor

Description

@BenAHammond BenAHammond mentioned this pull request Jun 13, 2024
Closed
@vladmoroz
Copy link
Collaborator

Thanks @BenAHammond, could you go throw "Tracking version changes" step mentioned in the release process and note each primitive package change as a patch? We'll be able to merge the PR then.

@BenAHammond
Copy link
Contributor Author

Thanks @BenAHammond, could you go throw "Tracking version changes" step mentioned in the release process and note each primitive package change as a patch? We'll be able to merge the PR then.

Interestingly those instructions aren't working for me. I see files generated:

ls .yarn/versions/
1f1ba8b4.yml	2ab74363.yml	5793010b.yml	60c2f256.yml	75dcd823.yml	c9fc51b8.yml	dc4b1017.yml	ded3a040.yml	eb020608.yml	f4333956.yml
261663d9.yml	54d1ffa8.yml	58957da5.yml	70d7cf62.yml	b20a66e3.yml	d226e89e.yml	dd1eb89d.yml	e97b6ff3.yml	efa9f1f5.yml	fad3e42d.yml

but there's nothing to add in git? I'm guessing this is a .gitignore setting or I am doing something wrong:

git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

@vladmoroz
Copy link
Collaborator

Not sure, out gitignore is set up to not ignore .yarn/versions. Anyway, I've pushed version updates to your branch and will merge now.

@BenAHammond
Copy link
Contributor Author

Thank you!

@vladmoroz vladmoroz merged commit 5dce55e into radix-ui:main Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmoroz vladmoroz vladmoroz approved these changes

@StephenHaney StephenHaney Awaiting requested review from StephenHaney StephenHaney is a code owner

@lucasmotta lucasmotta Awaiting requested review from lucasmotta lucasmotta is a code owner

@hadihallak hadihallak Awaiting requested review from hadihallak hadihallak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenAHammond @vladmoroz